Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document/clarify how "keyboard.touchbar.ignored" affects extensions #87980

Closed
DanTup opened this issue Jan 2, 2020 · 6 comments
Closed

Document/clarify how "keyboard.touchbar.ignored" affects extensions #87980

DanTup opened this issue Jan 2, 2020 · 6 comments
Assignees
Labels
*as-designed Described behavior is as designed info-needed Issue requires more information from poster

Comments

@DanTup
Copy link
Contributor

DanTup commented Jan 2, 2020

I had a request in my extension to honour the keyboard.touchbar.ignored setting to hide items from the touchbar. There's nothing in the docs about the expectations here - if the array is just populated with command IDs, it would be better for VS Code to handle this (to avoid every extension that contributes touchbar buttons having to do it).

Otherwise, if it's the extensions responsibility to do this, it should be made clear somewhere in the docs (for example on https://code.visualstudio.com/api/references/contribution-points).

@bpasero
Copy link
Member

bpasero commented Jan 4, 2020

Yes, this setting literally contains the IDs of actions/commands to not show in the touchbar. It should just work for your touchbar actions if the user configures the identifier. Does it not?

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 4, 2020
@DanTup
Copy link
Contributor Author

DanTup commented Jan 4, 2020

Oh, I see the issue... The problem is that in order to have different text on the TouchBar from the Command Palette (the touchbar has much less space so has to have the names shortened) we have to have extra commands. In this case the touchbar has a hidden command ("_flutter.screenshot.touchBar") and the user was using the command it delegates too.

I guess it's working-as-intended, but it doesn't feel ideal to have to have the user exclude using private command names, or having to compromise the command palette text to match that for the touchbar.

@bpasero
Copy link
Member

bpasero commented Jan 4, 2020

This came in via #70174. Maybe you ping the author about the issues you see with this feature.

@bpasero bpasero added the *as-designed Described behavior is as designed label Jan 4, 2020
@vscodebot
Copy link

vscodebot bot commented Jan 4, 2020

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jan 4, 2020
@DanTup
Copy link
Contributor Author

DanTup commented Jan 4, 2020

@bpasero I'm not sure there's a great fix besides being able to have a single command with different text labels for touchBar vs commandPalette so it'd probably need a decision from the Code team whether they'd want to support something like that. Another option would be to use icons, though for some things it's hard to come up with icons that wouldn't be vague.

@bpasero
Copy link
Member

bpasero commented Jan 4, 2020

I am not sure what you are asking for. keyboard.touchbar.ignored is well defined. The user can add the identifier of a command to exclude it from the macOS touchbar. That is pretty much the entirety of what this setting does.

If you think something is missing in this area (e.g. allowing the user to hide commands from the command palette), I would suggest to open a separate feature request.

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants