-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document/clarify how "keyboard.touchbar.ignored" affects extensions #87980
Comments
Yes, this setting literally contains the IDs of actions/commands to not show in the touchbar. It should just work for your touchbar actions if the user configures the identifier. Does it not? |
Oh, I see the issue... The problem is that in order to have different text on the TouchBar from the Command Palette (the touchbar has much less space so has to have the names shortened) we have to have extra commands. In this case the touchbar has a hidden command ("_flutter.screenshot.touchBar") and the user was using the command it delegates too. I guess it's working-as-intended, but it doesn't feel ideal to have to have the user exclude using private command names, or having to compromise the command palette text to match that for the touchbar. |
This came in via #70174. Maybe you ping the author about the issues you see with this feature. |
The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines. Happy Coding! |
@bpasero I'm not sure there's a great fix besides being able to have a single command with different text labels for touchBar vs commandPalette so it'd probably need a decision from the Code team whether they'd want to support something like that. Another option would be to use icons, though for some things it's hard to come up with icons that wouldn't be vague. |
I am not sure what you are asking for. If you think something is missing in this area (e.g. allowing the user to hide commands from the command palette), I would suggest to open a separate feature request. |
I had a request in my extension to honour the
keyboard.touchbar.ignored
setting to hide items from the touchbar. There's nothing in the docs about the expectations here - if the array is just populated with command IDs, it would be better for VS Code to handle this (to avoid every extension that contributes touchbar buttons having to do it).Otherwise, if it's the extensions responsibility to do this, it should be made clear somewhere in the docs (for example on https://code.visualstudio.com/api/references/contribution-points).
The text was updated successfully, but these errors were encountered: