Assertion in onWillDelete/onDidDelete test failing but not failing test

[Tyriar]

This is failing:

vscode/extensions/vscode-api-tests/src/singlefolder-tests/workspace.event.test.ts

Line 162 in f29b55c

assert.ok(once);

The expression evaluated to a falsy value:

  assert.ok(once)
: AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: The expression evaluated to a falsy value:

  assert.ok(once)

    at D:\a\1\s\extensions\vscode-api-tests\src\singlefolder-tests\workspace.event.test.ts:162:11
    at wrapped (d:\a\1\s\out\vs\workbench\api\common\file:\D:\a\1\s\src\vs\workbench\api\common\extHostFileSystemEventService.ts:176:85)
    at AsyncEmitter.fireAsync (d:\a\1\s\out\vs\base\common\file:\D:\a\1\s\src\vs\base\common\event.ts:692:15)
    at ExtHostFileSystemEventService._fireWillEvent (d:\a\1\s\out\vs\workbench\api\common\file:\D:\a\1\s\src\vs\workbench\api\common\extHostFileSystemEventService.ts:202:17)
    at ExtHostFileSystemEventService.$onWillRunFileOperation (d:\a\1\s\out\vs\workbench\api\common\file:\D:\a\1\s\src\vs\workbench\api\common\extHostFileSystemEventService.ts:188:16)
    at RPCProtocol._doInvokeHandler (d:\a\1\s\out\vs\workbench\services\extensions\common\file:\D:\a\1\s\src\vs\workbench\services\extensions\common\rpcProtocol.ts:398:17)
    at RPCProtocol._invokeHandler (d:\a\1\s\out\vs\workbench\services\extensions\common\file:\D:\a\1\s\src\vs\workbench\services\extensions\common\rpcProtocol.ts:383:32)
    at RPCProtocol._receiveRequest (d:\a\1\s\out\vs\workbench\services\extensions\common\file:\D:\a\1\s\src\vs\workbench\services\extensions\common\rpcProtocol.ts:295:19)
    at RPCProtocol._receiveOneMessage (d:\a\1\s\out\vs\workbench\services\extensions\common\file:\D:\a\1\s\src\vs\workbench\services\extensions\common\rpcProtocol.ts:235:10)
    at d:\a\1\s\out\vs\workbench\services\extensions\common\file:\D:\a\1\s\src\vs\workbench\services\extensions\common\rpcProtocol.ts:101:42
    at Emitter.fire (d:\a\1\s\out\vs\base\common\file:\D:\a\1\s\src\vs\base\common\event.ts:581:16)
    at BufferedEmitter.fire (d:\a\1\s\out\vs\base\parts\ipc\common\file:\D:\a\1\s\src\vs\base\parts\ipc\common\ipc.net.ts:453:19)
    at d:\a\1\s\out\vs\workbench\services\extensions\node\file:\D:\a\1\s\src\vs\workbench\services\extensions\node\extensionHostProcessSetup.ts:192:22
    at Emitter.fire (d:\a\1\s\out\vs\base\common\file:\D:\a\1\s\src\vs\base\common\event.ts:581:16)
    at BufferedEmitter.fire (d:\a\1\s\out\vs\base\parts\ipc\common\file:\D:\a\1\s\src\vs\base\parts\ipc\common\ipc.net.ts:453:19)
    at PersistentProtocol._receiveMessage (d:\a\1\s\out\vs\base\parts\ipc\common\file:\D:\a\1\s\src\vs\base\parts\ipc\common\ipc.net.ts:733:21)
    at d:\a\1\s\out\vs\base\parts\ipc\common\file:\D:\a\1\s\src\vs\base\parts\ipc\common\ipc.net.ts:592:73
    at Emitter.fire (d:\a\1\s\out\vs\base\common\file:\D:\a\1\s\src\vs\base\common\event.ts:581:16)
    at ProtocolReader.acceptChunk (d:\a\1\s\out\vs\base\parts\ipc\common\file:\D:\a\1\s\src\vs\base\parts\ipc\common\ipc.net.ts:239:21)
    at d:\a\1\s\out\vs\base\parts\ipc\common\file:\D:\a\1\s\src\vs\base\parts\ipc\common\ipc.net.ts:200:51
    at Socket.listener (d:\a\1\s\out\vs\base\parts\ipc\node\file:\D:\a\1\s\src\vs\base\parts\ipc\node\ipc.net.ts:28:38)
    at Socket.emit (events.js:200:13)
    at addChunk (_stream_readable.js:294:12)
    at readableAddChunk (_stream_readable.js:275:11)
    at Socket.push (_stream_readable.js:210:10)
    at Pipe.onStreamRead (internal/stream_base_commons.js:166:17)
{ fileOperationResult: 1 }
    √ onWillDelete/onDidDelete, make changes, double delete (85ms)

For async assertions you need to try catch and pass the error to done (or reject promise?):

try {
  assert.ok(once);
} catch (e) {
  done(e);
}

https://dev.azure.com/vscode/VSCode/_build/results?buildId=34224&view=logs&j=2d2b3007-3c5c-5840-9bb0-2b1ea49925f3&t=4f94dfce-af9e-52fd-5eb8-ca3006505634