Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In markdown hover, hr overlaps following codeblock #88416

Closed
sam-mccall opened this issue Jan 10, 2020 · 2 comments
Closed

In markdown hover, hr overlaps following codeblock #88416

sam-mccall opened this issue Jan 10, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover

Comments

@sam-mccall
Copy link

Issue Type: Bug

If our LSP server returns the following hover content:

function `x`

---

```cpp
void x();
```

It renders poorly:

image

No spacing between HR and the code block, and in fact they overlap.
This is due to the negative margin of -6px added by @dbaeumer in 6d83770 to fix other problems in rendering.

Removing that -6px makes it render much better, but presumably breaks other things:

image

VS Code version: Code 1.39.2 (6ab5985, 2019-10-15T15:33:40.634Z)
OS version: Linux x64 5.2.17-1rodete3-amd64

System Info
Item Value
CPUs Intel(R) Xeon(R) CPU E5-2690 v3 @ 2.60GHz (48 x 1197)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: disabled_software
skia_deferred_display_list: disabled_off
skia_renderer: disabled_off
surface_synchronization: enabled_on
video_decode: unavailable_off
viz_display_compositor: disabled_off
webgl: enabled
webgl2: enabled
Load (avg) 1, 1, 1
Memory (System) 62.88GB (19.36GB free)
Process Argv /usr/local/google/home/sammccall/test.cc
Screen Reader no
VM 0%
Extensions (2)
Extension Author (truncated) Version
vscode-clangd llv 0.0.19
vim vsc 1.0.3
@vscodebot vscodebot bot added the terminal Integrated terminal issues label Jan 10, 2020
@dbaeumer dbaeumer added editor-hover Editor mouse hover and removed terminal Integrated terminal issues labels Jan 10, 2020
@dbaeumer dbaeumer self-assigned this Jan 10, 2020
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Jan 10, 2020
@dbaeumer
Copy link
Member

dbaeumer commented Nov 2, 2020

I fixed that a while back ago. Please ping if you are still experiencing this.

@dbaeumer dbaeumer closed this as completed Nov 2, 2020
@sam-mccall
Copy link
Author

No, looks fixed to me. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-hover Editor mouse hover
Projects
None yet
Development

No branches or pull requests

2 participants