Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote badge in extension viewlet only respects remoteForeground when its focused #88863

Closed
Tyriar opened this issue Jan 17, 2020 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue themes Color theme issues verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 17, 2020

For these settings:

"workbench.colorCustomizations": {
    "extensionBadge.remoteForeground": "#ff0000",
    "extensionBadge.remoteBackground": "#0000ff"
},

image

It looks especially bad when you invert the color

image

@Tyriar
Copy link
Member Author

Tyriar commented Jan 17, 2020

It also doesn't apply in the webview

image

@sandy081
Copy link
Member

Its an icon in the badge and hence the foreground is not applied.

@misolori Is it possible to theme its colour?

@sandy081 sandy081 added the polish Cleanup and polish issue label Jan 21, 2020
@miguelsolorio miguelsolorio added the themes Color theme issues label Jan 27, 2020
@rediffusion
Copy link

rediffusion commented Feb 7, 2020

@Tyriar

When do these small icons appear? When you installed some extensions on the remote server? Or maybe in «VS Code» when you click on the extension icon "Remote Explorer > CONTAINERS":

image

@Tyriar
Copy link
Member Author

Tyriar commented Feb 7, 2020

@rediffusion in the extension viewlet when you install remote extensions.

@miguelsolorio miguelsolorio added this to the February 2020 milestone Feb 10, 2020
@Tyriar Tyriar reopened this Feb 19, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Feb 19, 2020

Not fixed yet

@miguelsolorio miguelsolorio added the bug Issue identified by VS Code Team member as probable bug label Feb 24, 2020
@miguelsolorio
Copy link
Contributor

Verification steps:

  1. Use the same steps in the original issue
  2. Verify that the overrides work in both narrow and large sidebar views, and in the extension detail page

@alexr00 alexr00 added the verified Verification succeeded label Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug polish Cleanup and polish issue themes Color theme issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants