Auto closing quotes in makefiles (*.mk)

[ZYinMD]

I found a tiny issue: quotes don't auto-close in makefiles (*.mk), but brackets do. It's because makefile didn't define any surroundingPairs or autoClosingPairs in its language-configuration.json, but did define brackets, and the fallback logic is here.

I'm not an expert, but I think makefile does use double and single quotes for strings.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Unable to force tabs for Makefile (#76000)

[rzhao271]

Brackets don't autocomplete for me now in makefiles, but I'm not sure if part of the original feature request was to keep that behaviour, hence author-verification-requested.

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@ZYinMD, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version f4187f2 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[jrieken]

I have a test.mk file, it shows Makefile at the bottom but when typing any of (,[,{ no auto closing happens

[alexr00]

Thanks for catching!