Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: allow built-in extensions on different qualities #89199

Merged
merged 1 commit into from Jan 24, 2020

Conversation

connor4312
Copy link
Member

Adds a new optional forQualities property to built-in extensions,
and filters that as appropriate for different builds.

Adds a new optional `forQualities` property to built-in extensions,
and filters that as appropriate for different builds.
@connor4312 connor4312 force-pushed the feat/quality-builtin-extensions branch from 6aca9ca to a6bef78 Compare January 23, 2020 22:38
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me. Feel free to merge if works as intended.

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Jan 24, 2020
@connor4312 connor4312 merged commit 7ad58a9 into master Jan 24, 2020
@connor4312 connor4312 deleted the feat/quality-builtin-extensions branch January 24, 2020 15:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants