Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring TS watchFileOptions #89381

Closed
mjbvz opened this issue Jan 27, 2020 · 1 comment
Closed

Support configuring TS watchFileOptions #89381

mjbvz opened this issue Jan 27, 2020 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jan 27, 2020

Tracks support for configuring the new TS watch options at the server level

@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues labels Jan 27, 2020
@mjbvz mjbvz self-assigned this Jan 27, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Jan 27, 2020
@mjbvz mjbvz modified the milestones: Backlog Candidates, Backlog Jan 27, 2020
@microsoft microsoft deleted a comment from vscodebot bot Jan 27, 2020
@mjbvz mjbvz modified the milestones: Backlog, February 2020 Feb 8, 2020
@mjbvz mjbvz closed this as completed in 718331d Feb 8, 2020
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Feb 24, 2020
@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 24, 2020

To verify:

  1. Enable TS Server logging
  2. Try configuring the new options (note that we intentionally want users to edit the settings.json instead of using our settings editor here since this is an advanced setting)
  3. Open a TS file
  4. Change a watch option
  5. Run the TypeScript: Open ts server logs command

In the logs, confirm that your watch options have been applied. There should be lines that look like:

    {"seq":0,"type":"request","command":"configure","arguments":{"hostInfo":"vscode","preferences":{"providePrefixAndSuffixTextForRename":true,"allowRenameOfImportPath":true},"watchOptions":{"watchFile":"useFsEvents"}}}
Info 6    [14:45:52.89] Host information vscode
Info 7    [14:45:52.90] Host watch options changed to {"watchFile":3}, it will be take effect for next watches.

@connor4312 connor4312 added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Feb 26, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants