Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A visible Timeline results in a lot of visual noise #89509

Closed
Tyriar opened this issue Jan 28, 2020 · 4 comments
Closed

A visible Timeline results in a lot of visual noise #89509

Tyriar opened this issue Jan 28, 2020 · 4 comments
Assignees
Labels
timeline Timeline view issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 28, 2020

#89385

Version: 1.42.0-insider (user setup)
Commit: c4b6a6b
Date: 2020-01-28T05:38:41.922Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.19041

When working with the timeline view opened I find it quite distracting as every time the file changes the view has all text removed and then fills in for the new file. One idea to prevent this is to disable the items in the view but leave them there until the new items are ready (or until some short timeout has elapsed), that way it would change from a full view to another full view.

@eamodio eamodio added the timeline Timeline view issues label Jan 28, 2020
@eamodio
Copy link
Contributor

eamodio commented Feb 5, 2020

@Tyriar I think I have improved things a bit in master. Can you check it out in tomorrow's insiders? To me it feels the same as the Outline view.

@Tyriar
Copy link
Member Author

Tyriar commented Feb 7, 2020

@eamodio it still flashes empty and then full though?

When flipping between 2 files multiple times, one appears to be cached and the other not?

Kapture 2020-02-07 at 7 55 44

@eamodio eamodio closed this as completed in afacd2b Mar 1, 2020
@eamodio eamodio added this to the March 2020 milestone Mar 1, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Mar 2, 2020

@eamodio what was the fix that happened here?

@eamodio
Copy link
Contributor

eamodio commented Mar 2, 2020

After discussion in Friday's standup, we will now not update the view until we've loaded the fastest provider for the new file, and if the user interacts (clicks on, etc) any of the items in the view while we are still loading, then the view will switch to the "loading" state.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
timeline Timeline view issues
Projects
None yet
Development

No branches or pull requests

2 participants