Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If the variable request returns an error response do not show leading colon #89709

Closed
isidorn opened this issue Jan 30, 2020 · 0 comments
Closed

If the variable request returns an error response do not show leading colon #89709

isidorn opened this issue Jan 30, 2020 · 0 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
February 2020

Comments

@isidorn
Copy link
Contributor

isidorn commented Jan 30, 2020

from @weinand
If the variable request returns an error response 'foo bar' it shows up in the UI as:

image

To emphasize that this is an error I suggest a change to the error format: don't show the leading space and the colon ':', just show the error message.
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jan 30, 2020
@isidorn isidorn added this to the February 2020 milestone Jan 30, 2020
@isidorn isidorn self-assigned this Jan 30, 2020
@isidorn isidorn mentioned this issue Jan 30, 2020
Closed
@isidorn isidorn closed this as completed in bee7a6e Feb 7, 2020
@connor4312 connor4312 added the verified Verification succeeded label Feb 27, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
February 2020
Development

No branches or pull requests
2 participants
@isidorn @connor4312