Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Contributions" to "Feature Contributions" #89842

Merged
merged 3 commits into from Feb 6, 2020
Merged

Rename "Contributions" to "Feature Contributions" #89842

merged 3 commits into from Feb 6, 2020

Conversation

bepvte
Copy link
Contributor

@bepvte bepvte commented Feb 1, 2020

This PR fixes #89753

This changes the title of the "Contributions" tab to "Feature Contributions", for clarity.
I don't know if I should somehow mark this as needing to be retranslated, and how I would go about that.

@sandy081
Copy link
Member

sandy081 commented Feb 6, 2020

I would rename only the label and not internal keys. I will take care of it.

@sandy081 sandy081 self-requested a review February 6, 2020 19:07
@sandy081 sandy081 added this to the February 2020 milestone Feb 6, 2020
@sandy081 sandy081 added the extensions Issues concerning extensions label Feb 6, 2020
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandy081 sandy081 merged commit 7150d73 into microsoft:master Feb 6, 2020
@bepvte bepvte deleted the bepvte/contributions-rename branch February 6, 2020 22:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename contributions page in extension view
2 participants