Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIM API Gaps #8997

Closed
4 tasks done
egamma opened this issue Jul 9, 2016 · 10 comments
Closed
4 tasks done

VIM API Gaps #8997

egamma opened this issue Jul 9, 2016 · 10 comments
Assignees
Labels
plan-item VS Code - planned item for upcoming
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jul 9, 2016

From @johnfn in #8760

I'm a Vim extension developer and I noticed you guys wanted to know the API gaps. I made an issue for each gap I'm aware of: #2771, #8096, #1431, #8094, #8093, #7177.
#2771 is the highest priority because it can't be worked around.
#8096 is also really important because although it can be worked around, I'm scared of breaking user's history.

The rest would be very nice to have.

Features:

Bugs:

@egamma egamma added the plan-item VS Code - planned item for upcoming label Jul 9, 2016
@egamma egamma added this to the July 2016 milestone Jul 9, 2016
@egamma egamma mentioned this issue Jul 9, 2016
89 tasks
@kieferrm
Copy link
Member

Also includes #9143.

@rebornix
Copy link
Member

rebornix commented Jul 20, 2016

Short summary of current Vim API gaps:

CJK

it's about #8133.
We had CJK IME issues with VS Code and not enough API exposed for external callers. Alex already fixed those bugs and provided two composing APIs, now CJK should be pefect. What's more, our Integrated Terminal also benefits from it #8892.

Scrolling

it's about #2771, #9143, #9220.
@sandy081 already provided us an API for moving cursors to screen lines/characters and they work great.

  1. Move cursor to specific Screen Line or line start, middle or end.
  2. Lines in Visible Window. Eg, go to the Nth/Middle line in the window, go to the Nth line from the bottom
  3. Screen characters. Scroll screen N characters, it's likely an addition to gm.

Windows and Tabs

  1. API Request: Move Tab #8234 and Add commands to move tabs left and right in group #9333 are about moving Tabs to a specific index

Backlog

@sandy081
Copy link
Member

I am removing Scroll Window/Page feature from the current plan. We will take a look at it for next iteration.

@kieferrm
Copy link
Member

@sandy081 which issue do you defer?

@kieferrm
Copy link
Member

@sandy081: @rebornix and I just ranked the backlog in the comment above to correctly reflect the priorities from the VIM perspective.

@rebornix
Copy link
Member

rebornix commented Jul 22, 2016

@sandy081 updated my summary and added 4 more separate items. Now they covered all missing features currently on our roadmap, those commands/motions on our roadmap are from Vim's quickref so if there is any missing command that's dependent on VS Code API support but not listed in Vim documentation, I'll update this summary.

@sandy081
Copy link
Member

sandy081 commented Jul 22, 2016

@kieferrm Item I deferred is scrolling window / page feature - #9609

@sandy081
Copy link
Member

@rebornix I moved Scrolling and other Tabs items to backlog in above comment. Please arrange them in the order of Vim extension priority.

Thanks.

@rebornix
Copy link
Member

Implement all commands that are currently possible with @sandy081 's newly added API. Others are all moved to Backlog section, ordered by priorities.

@egamma
Copy link
Member Author

egamma commented Jul 28, 2016

This work will continue in August - moving the milestone accordingly

@egamma egamma modified the milestones: August 2016, July 2016 Jul 28, 2016
@sandy081 sandy081 modified the milestones: September 2016, August 2016 Aug 31, 2016
@sandy081 sandy081 closed this as completed Feb 2, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plan-item VS Code - planned item for upcoming
Projects
None yet
Development

No branches or pull requests

4 participants