Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover previews for JSDoc comments show truncated @param parameter names when they include non-ASCII characters #90108

Closed
patricio-ezequiel-hondagneu-roig opened this issue May 25, 2019 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Milestone

Comments

@patricio-ezequiel-hondagneu-roig

Issue Type: Bug

  1. Create a new .ts file
  2. Paste this sample
class Test {
	anotherMethod() {
		this.problematicMethod();
	}

	/**
	 * @param parameterWithoutDiacritics this will work
	 * @param parámetroConDiacríticos this will not
	 */
	problematicMethod(parameterWithoutDiacritics, parámetroConDiacríticos) {}
}
  1. Hover the this.problematicMethod() method invocation on line 3
  2. Observe how the name of the second parameter is truncated after the first non-ASCII character (in this case, the letter á)

This problem happens even with all extensions disabled.

VS Code version: Code 1.34.0 (a622c65, 2019-05-15T21:59:37.030Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz (4 x 2712)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 7.87GB (3.79GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (24)
Extension Author (truncated) Version
Bookmarks ale 10.4.3
scope-bar amo 0.2.1
npm-intellisense chr 1.3.0
dart-code Dar 3.0.2
flutter Dar 3.0.2
githistory don 0.4.6
gitlens eam 9.8.1
EditorConfig Edi 0.13.0
vscode-npm-script eg2 0.3.7
auto-rename-tag for 0.0.15
todo-tree Gru 0.0.132
expand-region let 0.1.2
Angular-BeastCode Mik 8.0.7
vscode-scss mrm 0.6.2
vscode-typescript-tslint-plugin ms- 1.1.0
vsliveshare ms- 1.0.249
debugger-for-chrome msj 4.11.3
vetur oct 0.21.0
material-icon-theme PKi 3.7.0
code-settings-sync Sha 3.2.9
language-stylus sys 1.11.0
stylus-supremacy thi 2.12.7
vscode-icons vsc 8.6.0
vscode-jumpy wma 0.3.1
@mjbvz mjbvz self-assigned this May 25, 2019
@mjbvz mjbvz transferred this issue from microsoft/vscode May 25, 2019
@mjbvz
Copy link
Contributor

mjbvz commented May 25, 2019

Confirmed with TS 3.5.0-dev.20190525

@mjbvz mjbvz removed their assignment May 25, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 5, 2020

Looks like TS gives us the correct response so moving back to VS Code

Result: {
    "kind": "method",
    "kindModifiers": "",
    "start": {
        "line": 3,
        "offset": 8
    },
    "end": {
        "line": 3,
        "offset": 25
    },
    "displayString": "(method) Test.problematicMethod(parameterWithoutDiacritics: any, parámetroConDiacríticos: any): void",
    "documentation": "",
    "tags": [
        {
            "name": "param",
            "text": "parameterWithoutDiacritics this will work"
        },
        {
            "name": "param",
            "text": "parámetroConDiacríticos this will not"
        }
    ]
}

@mjbvz mjbvz transferred this issue from microsoft/TypeScript Feb 5, 2020
@mjbvz mjbvz self-assigned this Feb 5, 2020
@mjbvz mjbvz added this to the February 2020 milestone Feb 5, 2020
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues labels Feb 5, 2020
@mjbvz mjbvz closed this as completed in 5347c21 Feb 5, 2020
@dbaeumer dbaeumer added the verified Verification succeeded label Feb 27, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug javascript JavaScript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants