Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decoration for symbolic link not showing up in this case #90119

Closed
bpasero opened this issue Feb 6, 2020 · 3 comments
Closed

Decoration for symbolic link not showing up in this case #90119

bpasero opened this issue Feb 6, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 6, 2020

Steps to Reproduce:

  1. create a folder with a couple of files and one symbolic link (ln -s <existing file> <symlink name>)
  2. open this folder in VSCode
  3. notice how the symlink correctly gets the arrow decoration for sym link
  4. click on the link to open it
  5. reload window

=> 🐛 the decoration does not appear anymore. it seems that as soon as an editor is opened matching the symlink, the decoration is not resolved?

Somehow does not reproduce in current insiders, so I wonder what changed here and if it could possibly be my change from yesterday, but I do not understand the correlation.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Feb 6, 2020
@isidorn
Copy link
Contributor

isidorn commented Feb 6, 2020

If it does not reproduce in current insiders I will look at it as fixed :)

For more details we could put a breakpoint here
And check what is the state that the ExplorerItem is in when we are asked to provide decorations.

@bpasero
Copy link
Member Author

bpasero commented Feb 6, 2020

@isidorn maybe I was not clear, this fails running out of sources and our insiders is not up to date.

@isidorn
Copy link
Contributor

isidorn commented Feb 7, 2020

Looked into this and it is a timing issue.
If you open the file in an editor it will try to get the decoration provided before the Explorer has a chance to resolve it (because the tab area is rendered before the explorer area).
Thinking about a solution...

@isidorn isidorn added this to the February 2020 milestone Feb 7, 2020
@isidorn isidorn closed this as completed in 91f5a4b Feb 7, 2020
@bpasero bpasero added the verified Verification succeeded label Feb 25, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants