Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a file in explorer view also opens a previously focused file #90140

Closed
webczat opened this issue Feb 6, 2020 · 4 comments
Closed

Creating a file in explorer view also opens a previously focused file #90140

webczat opened this issue Feb 6, 2020 · 4 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues

Comments

@webczat
Copy link

webczat commented Feb 6, 2020

environment:
Version: 1.42.0-insider
Commit: ae08d54
Date: 2020-02-05T20:04:52.050Z
Electron: 6.1.6
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Linux x64 5.5.2-arch1-1

I am not sure if this issue is specific to the fact that I am navigating vscode by keyboard or not...
It seems that creating a new file when another file is selected in vscode opens both the new file and the previously selected one.

Steps to reproduce:

  • Launch vscode and go to explorer view with some folder opened,
  • Select (but not open) some file for example README.md,
  • Press the "new file" on the toolbar to create a new file,
  • type new filename and press enter

expected result:

new file is created and opened

actual results:

new file is created and opened, but the previously selected file is also opened with it.

@isidorn
Copy link
Contributor

isidorn commented Feb 7, 2020

This is an actual issue, however we already have it captured here #87524
So let's close this issue as a duplicate and continue the conversation there.
We have this behavior from way back that focus on explorer automatically opens the file, however I personalyl would remove it. Some details here #67708

Anyways I am in discussion with @bpasero on this and we might change the behavior, follow #87524 for details. Thanks

@isidorn isidorn added *duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues labels Feb 7, 2020
@vscodebot
Copy link

vscodebot bot commented Feb 7, 2020

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Feb 7, 2020
@webczat
Copy link
Author

webczat commented Feb 7, 2020

I hit the mentioned issue, but I am not fully certain if they are the same. :) Maybe after I get a build with this one fixed I will be able to check.

@isidorn
Copy link
Contributor

isidorn commented Feb 7, 2020

They are the same, I am fully certain :)
The build should be out next week so let us know then.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

2 participants