"Auto Find in Selection = never" is ignored

[rstarkov]

• VSCode Version: 1.41.1
• OS Version: Win10

Steps to Reproduce:

1. Start code without extensions
2. Double check that Auto Find in Selection is set to "never"
3. Select two words
4. Press Ctrl+F

Expected: "find in selection" is off

Actual: "find in selection" is on, meaning I'm going to find exactly one match. Moreover, "find in selection" is just always on. Even when there is no selection. In 1.37.1 the button was disabled when there was no selection. Now the button is always enabled, and always activated.

Does this issue occur when all extensions are disabled?: Yes

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Find in selection doesn't work for selection in single line in some cases (#70298)

[rstarkov]

The most recent version in which this setting worked the way I'd expect it to is 1.39.2.

[xgdgsc]

I also started noticing this annoying regression recently.

[xgdgsc]

This seems only happens for me on win10, ubuntu doesn' t have this issue.

[rebornix]

I didn't reproduce this issue on Windows or other platforms. Do you run into the same issue if you comment out all the settings temporarily?

[xgdgsc]

Removing "editor.find.autoFindInSelection": true, from config works. Don' t remember when added that.

[rebornix]

@xgdgsc thanks, it means our code is not backwards compatible, will look into why that happens, thanks!

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[rstarkov]

@rebornix did this get closed by mistake? I can confirm that this was exactly like xgdgsc described.

[Will-W]

I had the same issue, having never set this setting. Specifically:

Steps

• editor.find.autoFindInSelection set to its default value (never)
• Select a word (that appears multiple times on the page)
• Press ctrl+f to bring up the find box

Expected:

• Find in selection unchecked, and multiple results are found

Actual

• Find in selection is checked, and only one result is found (because it's searching in the one word selection).

If I explicitly set the setting to any of the three values (multiline, never or always), I get the correct result (as I understand it). If I now reset the setting in the settings UI, I still get the correct behaviour.

[greggman]

This is broken for me (although it's never worked for me). Wound up here looking for a solution

Here you can see nothing is selected. I press Cmd-F to find and search in selection is on. I turn it off, close the box., search again, it's back on. At the end I verify that auto-find-in-selection is set to never. I also testing with all extensions disabled.

[rebornix]

Root cause: Settings Editor (UI) doesn't support raw value validation. Please check the JSON content of your settings, you can find editor.find.autoFindInSelection: true, removing it can solve the problem.

Internally in Editor, we will convert true to always thus it always take effect but the settings editor will not do validation/convert.

vscode/src/vs/workbench/contrib/preferences/browser/settingsTree.ts

Lines 1037 to 1043 in 0e91558

	let idx = dataElement.setting.enum!.indexOf(dataElement.value);
	if (idx === -1) {
	idx = dataElement.setting.enum!.indexOf(dataElement.defaultValue);
	if (idx === -1) {
	idx = 0;
	}
	}

[greggman]

Well I checked my settings.json and you're correct it was set to true even though the setting UI claimed it was set to "never". I did not set it to true so some flow from where I started to now VSCode made it true.

Let me also point out though that right after I made that video I noticed the "search in selection" icon in the search UI doesn't always match the behavior of search. There were several times the button was highlighted "search in select" and yet it was not searching in just the selection.

[TobiasSekan]

Same here

1. Double left click a word, to mark it
2. Press Ctrl+F
3. Find in selection is always active (and is reactivated)

Option: never or 'multiline`

* Still present min. since Version 1.43
* Same in Version 1.44 from 09.04.2020

Oh 🙈 , I found the Problem on my PC

The user and workspace settings was not the same as the folder setting.

After correct this, it's work perfectly 👍

[roblourens]

Added generic checks that a setting value matches its schema type. If there is a mismatch it will look like this: