Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in files using extenstion API #9049

Closed
jaydenlin opened this issue Jul 11, 2016 · 10 comments
Closed

Find in files using extenstion API #9049

jaydenlin opened this issue Jul 11, 2016 · 10 comments
Assignees
Labels
api api-proposal feature-request Request for new features or functionality on-testplan
Milestone

Comments

@jaydenlin
Copy link

jaydenlin commented Jul 11, 2016

Hi VS code team,
I would like to make an extenstion using Find in FIles API.
Is there any way to trigger Find in Files via extension ?
I only find workspace.findFiles.
Thanks in advance.

@joaomoreno
Copy link
Member

cc @jrieken

@jaydenlin
Copy link
Author

Hi @jrieken,
Could you kindly provide any suggestion ?
Thank you.

@jrieken jrieken added feature-request Request for new features or functionality api labels Jul 12, 2016
@jrieken jrieken assigned jrieken and unassigned sandy081 Jul 12, 2016
@jrieken
Copy link
Member

jrieken commented Jul 12, 2016

That hasn't been exposed yet - mainly because we might change the search engine we use behind the covers which might lead to API breakage...

@jaydenlin
Copy link
Author

Hi @jrieken,
Okay.. I see.. Thank you for the reply.

@jrieken
Copy link
Member

jrieken commented Apr 11, 2017

@roblourens Are we in a good enough state to expose our find in files functionalities for extension authors? Especially wrt regex-searching will we make more changes or is this future proof?

@roblourens
Copy link
Member

Yeah, I think we could do this. Someone could implement something like #23931

@jrieken
Copy link
Member

jrieken commented Apr 11, 2017

Yeah, like my alternative reference ui: https://github.com/Microsoft/vscode-extension-samples/blob/master/contentprovider-sample/README.md

@DHedgecock
Copy link

Could this be used to create an extension allowing for full page results? This editor is so awesome, but the current find results showing in the sidebar is difficult to use in my opinion. I'd like to make an extension for executing a search and opening the results in an editor (similar to Atom search flow).

Excited to see this land!

@IlyaBiryukov
Copy link

Ideally, the search API should match SearchProvider API. Though, instead of registering a new search provider, the goal here is to be able to call it and get the search results. And that should work with the default provider that VSCode implements, when nobody else has actually registered one.

@IlyaBiryukov
Copy link

@jrieken when do you think it can land into VSCode?

@roblourens roblourens added this to the July 2018 milestone Jul 1, 2018
@roblourens roblourens reopened this Jul 11, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-proposal feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

No branches or pull requests

7 participants