tests - shutdown gracefully to enable webview tests #90508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
reviewed
Feb 12, 2020
| new Promise(c => { | ||
| const testWindow = BrowserWindow.getAllWindows()[0]; | ||
| if (testWindow && !testWindow.isDestroyed()) { | ||
| testWindow.on('closed', () => c()); |
There was a problem hiding this comment.
Would also want to check the validity of testWindow.webContents and listen to the event accordingly for the reasons mentioned here https://github.com/electron/electron/blob/master/spec-main/window-helpers.ts#L7-L20
There was a problem hiding this comment.
@deepak1556 ok see my latest commit
|
I actually think this change does not help: https://github.com/microsoft/vscode/runs/440525717#step:14:456 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
//cc @deepak1556