Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create sign in/sign out commands #90988

Closed
Tyriar opened this issue Feb 19, 2020 · 3 comments
Closed

Create sign in/sign out commands #90988

Tyriar opened this issue Feb 19, 2020 · 3 comments
Assignees
Labels
authentication Issues with the Authentication platform polish Cleanup and polish issue
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 19, 2020

The sign out command used to be part of the sync component (Sync: Sign Out), it should be part of core but its own component that manages multiple accounts, for example Account: Sign In, Account Sign Out.

@RMacfarlane RMacfarlane added authentication Issues with the Authentication platform polish Cleanup and polish issue labels Feb 19, 2020
@RMacfarlane RMacfarlane added this to the February 2020 milestone Feb 19, 2020
@Tyriar
Copy link
Member Author

Tyriar commented Feb 20, 2020

@RMacfarlane wouldn't a generic sign in command be better than extension-specific ones? I'd prefer to see in the command palette just "Account: Sign In" rather than "Microsoft: Sign in", "GitHub: Sign in", etc.

@KamasamaK
Copy link

@Tyriar And would that generic command then just display a QuickPick of the available providers?

@Tyriar
Copy link
Member Author

Tyriar commented Feb 24, 2020

Yes, consolidating the sign out logic into core such that provider extensions don't need to worry about it.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
authentication Issues with the Authentication platform polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants