Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"editor.suggest.insertMode": "replace" not working at start of work in TypeScript #91105

Closed
eamodio opened this issue Feb 20, 2020 · 4 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete typescript Typescript support issues verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Feb 20, 2020

Issue Type: Bug

Related #91104

VS Code version: Code - Insiders 1.43.0-insider (9c341b3, 2020-02-20T05:39:38.179Z)
OS version: Windows_NT x64 10.0.19041

System Info
Item Value
CPUs AMD Ryzen 9 3900X 12-Core Processor (24 x 3800)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
oop_rasterization: disabled_off
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
viz_display_compositor: enabled_on
viz_hit_test_surface_layer: disabled_off_ok
webgl: enabled
webgl2: enabled
Load (avg) undefined
Memory (System) 31.95GB (16.15GB free)
Process Argv
Screen Reader no
VM 0%
@jrieken
Copy link
Member

jrieken commented Feb 21, 2020

Yes - there is a reasonable default but every language needs to implement this by themselves

@mjbvz
Copy link
Contributor

mjbvz commented Feb 21, 2020

@eamodio Please share repo steps and example code

@eamodio
Copy link
Contributor Author

eamodio commented Feb 21, 2020

@mjbvz It happens when starting the auto-complete from a ., it seems to work if there is one or more characters

Fails:
image

Works:
image

@mjbvz mjbvz changed the title "editor.suggest.insertMode": "replace" not working with TypeScript "editor.suggest.insertMode": "replace" not working at start of work in TypeScript Feb 24, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 24, 2020

Repo

class Foo {
    bar = 1;
    bad = 1;

    foo() {
        this.bar
    }
}
  1. Place cursor after . in this.bar
  2. Trigger suggestions and accept a replacement for bad

Expected
this.bad

Actual
this.badbar (🐘)

@mjbvz mjbvz added suggest IntelliSense, Auto Complete typescript Typescript support issues labels Feb 24, 2020
@mjbvz mjbvz added this to the February 2020 milestone Feb 24, 2020
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Feb 24, 2020
@mjbvz mjbvz closed this as completed in a10e4cb Feb 24, 2020
@rebornix rebornix added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug suggest IntelliSense, Auto Complete typescript Typescript support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants