Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: undo no longer reveals #91203

Closed
bpasero opened this issue Feb 22, 2020 · 2 comments
Closed

Editor: undo no longer reveals #91203

bpasero opened this issue Feb 22, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 22, 2020

Steps to Reproduce:

  1. make a change to a line
  2. scroll it out of view
  3. undo

=> 馃悰 the line is not revealed where the undo happens

@bpasero bpasero added the editor label Feb 22, 2020
@bpasero bpasero added the regression Something that used to work is now broken label Feb 22, 2020
@alexdima
Copy link
Member

Thank you, good catch!

@alexdima alexdima added this to the February 2020 milestone Feb 23, 2020
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Feb 23, 2020
@houmark
Copy link

houmark commented Feb 24, 2020

Thanks for the regression fix @alexdima.

I also noticed one and think this can maybe be tweaked a bit more after trying the most recent nightly with the fix. On undo it's scrolling to the very first/last visible line in the editor. Maybe it could scroll a bit more so you get more context?

In a perfect world, it would remember where you were when you did the edit that you are now undoing to bring you back to the same position. If that's not possible, then at least a bit more context above or below.

@bpasero bpasero added the verified Verification succeeded label Feb 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug regression Something that used to work is now broken verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants