Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide better way for plaintext completion providers to opt out of being enabled in scm input #91310

Closed
mjbvz opened this issue Feb 24, 2020 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality scm General SCM compound issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 24, 2020

Problem
My extension registers completion providers using the following DocumentSelector(s):

  • All plain text files for any scheme: { langaugeId: 'plaintext' }
  • The scm input text area: { scheme: 'vscode', pattern: 'scm/**/input' }

We also allow users to enable or disable trigger characters for each of these individually. However I cannot currently register separate completion item providers for these two because the language ids are the same

Using the two above schemes, the provider ends up being enabled twice inside the scm input. It seem unexpected that all plaintext based completions would end up in the scm input

Ideas

@joaomoreno joaomoreno added this to the April 2020 milestone Feb 26, 2020
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Feb 26, 2020
@joaomoreno
Copy link
Member

Created a scminput mode with mimetype text/x-scm-input.

@joaomoreno joaomoreno added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Apr 9, 2020
@joaomoreno
Copy link
Member

cc @alexr00

@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Apr 9, 2020
@jrieken jrieken added the verified Verification succeeded label Apr 28, 2020
@jrieken
Copy link
Member

jrieken commented Apr 28, 2020

verified in source

@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality scm General SCM compound issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants