Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

password description needs polish #91399

Closed
isidorn opened this issue Feb 25, 2020 · 2 comments
Closed

password description needs polish #91399

isidorn opened this issue Feb 25, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2020

refs: #91152

"Set to true to show a password prompt that will not show the typed value."

We usualy use the term controls if it is a boolean, we do not nudge the user to set it to true.
Also there seems to be one negation at the end which might overcomplicate what you are trying to say.

All in all, I suggest the following
"Controls if a password prompt is shown. Password prompt hides the typed value."
Or some variation of that, consider using "text" instead of "value"

@alexr00 alexr00 added this to the February 2020 milestone Feb 25, 2020
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Feb 25, 2020
@alexr00
Copy link
Member

alexr00 commented Feb 25, 2020

This is directly copied from the quick input API documentation. @chrmarti, do you mind if I change it there too: "Controls if a password input is shown. Password input hides the typed text."

@chrmarti
Copy link
Contributor

@alexr00 Yes, please. Thanks!

@mjbvz mjbvz added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants