Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification: X button shows up if progress is collapsed #91414

Closed
bpasero opened this issue Feb 25, 2020 · 0 comments
Closed

Notification: X button shows up if progress is collapsed #91414

bpasero opened this issue Feb 25, 2020 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 25, 2020

When you have a notification with progress that is not having any buttons, we still show the X button.

Action:

class ToggleProgressAction extends Action {

	static readonly ID = 'workbench.action.ProgressAction';
	static readonly LABEL = nls.localize('ProgressAction', "ProgressAction");

	constructor(
		id: string,
		label: string,
		@IProgressService private readonly progressService: IProgressService
	) {
		super(id, label);
	}

	run(): Promise<void> {
		this.progressService.withProgress({
			location: ProgressLocation.Notification,
			title: `Some long running operation`
		}, progress => {
			return timeout(20000);
		});

		return Promise.resolve();
	}
}
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug workbench-notifications Notification widget issues labels Feb 25, 2020
@bpasero bpasero added this to the February 2020 milestone Feb 25, 2020
@bpasero bpasero self-assigned this Feb 25, 2020
@roblourens roblourens added the verified Verification succeeded label Feb 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Development

No branches or pull requests

2 participants