Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second level groups are not automatically expanded #91417

Closed
weinand opened this issue Feb 25, 2020 · 2 comments
Closed

second level groups are not automatically expanded #91417

weinand opened this issue Feb 25, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Feb 25, 2020

Testing #91095:

  • use vscode-mock-debug project
  • change the code in mockDebug.ts:85 to
      		if (text === 'start' || text === 'startCollapsed') {
      			e.body.group = text;
      			e.body.output = `group-${text}\n`;
      		}
      		if (text === 'end') {
      			e.body.group = text;
      			e.body.output = ``;
      		}
  • use a readme.md file with this content:
    log(start)
    log(arbitrary line of text)
    log(start)
    log(arbitrary line of text level 2)
    log(another line of text level 2)
    log(end)
    log(another line of text)
    log(end)
    
  • run the mock session with F5
  • step through the test input line by line

Observe:
second level nodes are not automatically expanded:
2020-02-25_17-45-23

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 25, 2020
@isidorn isidorn added this to the On Deck milestone Feb 25, 2020
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Feb 25, 2020
@connor4312
Copy link
Member

For me the first level groups are not automatically expanded either, running the latest from sources

image

@isidorn
Copy link
Contributor

isidorn commented Feb 27, 2020

I am not happy with the implementation of auto expand on my side, assignign to next milestone to look into a cleaner solution then.

@isidorn isidorn modified the milestones: On Deck, March 2020 Feb 27, 2020
@isidorn isidorn closed this as completed in 1d8df42 Mar 3, 2020
@weinand weinand added the verified Verification succeeded label Mar 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants