Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

e.show is not a function #91421

Closed
isidorn opened this issue Feb 25, 2020 · 1 comment
Closed

e.show is not a function #91421

isidorn opened this issue Feb 25, 2020 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2020

Refs: #91335

  1. Take the watch view and drop it into the panel
  2. Drag the watch view and drop it into the Extensions viewlet icon in activity bar
  3. Extensions viewlet gets broken -> there is an error in the developer tools console 馃悰

Reload does not fix the issue -> it would be great if we fix this issue this milestone.
Call stack

RR e.show is not a function: TypeError: e.show is not a function
    at file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6372:803
    at Array.map (<anonymous>)
    at ae.onDidAddViewDescriptors (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6372:794)
    at ae.create (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5635:380)
    at ae.create (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:6368:434)
    at t.create (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:3399:1008)
    at e.showComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5147:974)
    at e.doOpenComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5146:870)
    at e.openComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5146:402)
    at e.doOpenViewlet (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5716:343)
    at e.openViewlet (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5715:675)
    at t.CompositeDragAndDrop.openComposite (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5680:434)
    at t.CompositeDragAndDrop.drop (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5665:155)
    at Object.onDrop (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5652:843)
    at HTMLLIElement.<anonymous> (file:///Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:5538:528)
@sbatten sbatten added this to the February 2020 milestone Feb 25, 2020
@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Feb 25, 2020
@sbatten sbatten changed the title e.drop is not a function e.show is not a function Feb 25, 2020
@sbatten
Copy link
Member

sbatten commented Feb 26, 2020

fyi @sandy081, fixed by adding flag to container descriptor that rejects adding views. necessary for extensions viewlet.

@joaomoreno joaomoreno added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

3 participants