Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select a destination area for the view feedback #91422

Closed
isidorn opened this issue Feb 25, 2020 · 3 comments
Closed

Select a destination area for the view feedback #91422

isidorn opened this issue Feb 25, 2020 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Feb 25, 2020

Refs: #91335

Screenshot 2020-02-25 at 18 06 49

1 . There is no need for ... at the end of message
2. Start each word with Upper Case: "Select a Destination Area for the View"
3. Always preselect the part that the view is in, or is not. But do not default select sidebar always
4. "Sidebar" should be "Side Bar"

@isidorn
Copy link
Contributor Author

isidorn commented Feb 25, 2020

Same feedback for this message
Screenshot 2020-02-25 at 18 11 16

Actually consider just mergeing this two dialogs into one and using groups to group options together. First the Side Bar options than the Panel options

@sbatten sbatten added bug Issue identified by VS Code Team member as probable bug workbench-views Workbench view issues labels Feb 25, 2020
@sbatten sbatten added this to the February 2020 milestone Feb 25, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Feb 27, 2020

Can not verify this since the move focused view command now never works for me (already captured in the seperate issue). There is no view currently focused

@sbatten
Copy link
Member

sbatten commented Feb 27, 2020

To verifier: You must use a keyboard shortcut to run this command. In the next insiders build, it will not show up in the command palette to avoid confusion.

command workbench.action.moveFocusedView

@isidorn isidorn added the verified Verification succeeded label Feb 27, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded workbench-views Workbench view issues
Projects
None yet
Development

No branches or pull requests

2 participants