Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search editor doesn't play nice with provided links #91453

Closed
Tyriar opened this issue Feb 25, 2020 · 2 comments
Closed

Search editor doesn't play nice with provided links #91453

Tyriar opened this issue Feb 25, 2020 · 2 comments
Assignees
@JacksonKearl
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search-editor verified Verification succeeded
Milestone
November 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Feb 25, 2020

#1685 is a link from the GH extension, ctrl+clicking it appears like it attempts to open both the link and the search result.

image

Version: 1.43.0-insider (user setup)
Commit: 89cafb2
Date: 2020-02-25T05:29:49.719Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041
@JacksonKearl JacksonKearl added the bug Issue identified by VS Code Team member as probable bug label Feb 25, 2020
@JacksonKearl JacksonKearl added this to the Backlog milestone Feb 25, 2020
@JacksonKearl
Copy link
Contributor

Decided to just disable links in search editors.

@JacksonKearl JacksonKearl modified the milestones: Backlog, July 2020 Jul 11, 2020
@JacksonKearl JacksonKearl removed the insiders-released Patch has been released in VS Code Insiders label Jul 30, 2020
@JacksonKearl JacksonKearl reopened this Jul 30, 2020
@JacksonKearl
Copy link
Contributor

Reverted earlier commit as it made the header links also broken. Will find a better solution.

@JacksonKearl JacksonKearl modified the milestones: July 2020, Backlog Jul 30, 2020
@JacksonKearl JacksonKearl modified the milestones: Backlog, November 2020 Nov 6, 2020
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JacksonKearl JacksonKearl

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders search-editor verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
4 participants
@Tyriar @rzhao271 @JacksonKearl and others