Revealing settings or keybinding files in explorer

[Jupakabra]

Version: 1.43.0-insider
Commit: b0be067
OS: Windows_NT x64 10.0.17763

Steps to Reproduce:

1. Open settings.json in json format.
2. Reveal in explorer option is not there in the context menu or through a shortcut

Does this issue occur when all extensions are disabled?: Yes

Was this purposely removed for settings? Because it used to work before and now there is no way to get to settings files for backup or copy purposes.

[roblourens]

@aeschli maybe d0fd0e2? I think the settings file is not file: scheme

[sandy081]

@aeschli Can we enable this to the resource scheme - vscode-userdata and not in web?

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@Jupakabra, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 92192ba of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[Jupakabra]

Doesn't seem to work, at least in zip version.
It opens current project parent folder instead, or just documents folder if no project is loaded.
Also, current stable release allows opening it through a shortcut correctly, even thought reveal in explorer is not visible.

Version: 1.52.0-insider
Commit: 92192baf760315ac47fb2caaf3ce6d0778962352
Date: 2020-12-03T05:43:59.635Z
Electron: 9.3.5
Chrome: 83.0.4103.122
Node.js: 12.14.1
V8: 8.3.110.13-electron.0
OS: Windows_NT x64 10.0.19041

[roblourens]

@meganrogge you can reopen issues when you add verification-found

[sandy081]

It was working while fixed. After bisect, I figured out that Fix of #110353 broke this.

@isidorn FYI

[isidorn]

@sandy081 thanks a lot for investigating and for bisecting!
I reverted my commit and verified this now works as expected

[isidorn]

@JacksonKearl the bot is bullying me here :D

[rzhao271]

\closedWith 8f410da

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@Jupakabra, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version bc13785 of Insiders (today's or later - you can use Help: About in the command palette to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

[JacksonKearl]

@isidorn looking at the timeline I can't figure out why it was repeatedly commenting... it's expected to comment if author-verification-requested is added without a closing commit being found, but I don't know why it'd do it multiple times. I'd expect it to remove the author-verification-requested label instead.