Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comments panel default message #91623

Closed
sana-ajani opened this issue Feb 26, 2020 · 2 comments
Closed

Comments panel default message #91623

sana-ajani opened this issue Feb 26, 2020 · 2 comments
Assignees
@RMacfarlane
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2020

Comments

@sana-ajani
Copy link
Contributor

I was confused about where this panel came from and what would go in here. If I don't have the GHPR extension installed or a PR checked out, users might be confused by the message of this. Can we edit the message to reflect that certain extensions will contribute to this panel?

image
@RMacfarlane RMacfarlane added comments Comments Provider/Widget/Panel issues bug Issue identified by VS Code Team member as probable bug labels Feb 27, 2020
@RMacfarlane RMacfarlane added this to the March 2020 milestone Feb 27, 2020
@RMacfarlane RMacfarlane modified the milestones: March 2020, Backlog Apr 1, 2020
@RMacfarlane
Copy link
Contributor

The comments panel should only show up when there is an extension that registers a "CommentController" that could be used to add comments. Any chance you remember if you had something like LiveShare installed at this time?

I'll update the text to match the Problems panel, so that it says there are no comments in the workspace, rather than referencing a "review"

@RMacfarlane RMacfarlane modified the milestones: Backlog, November 2020 Nov 4, 2020
@sana-ajani
Copy link
Contributor Author

Yeah, I think I did have Liveshare installed.

@rzhao271 rzhao271 added the verified Verification succeeded label Dec 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2020
Development

No branches or pull requests
4 participants
@RMacfarlane @rzhao271 @sana-ajani and others