Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editors: revert() is missing? #91700

Closed
bpasero opened this issue Feb 27, 2020 · 1 comment
Closed

Custom editors: revert() is missing? #91700

bpasero opened this issue Feb 27, 2020 · 1 comment
Assignees
@mjbvz
Labels
api custom-editors Custom editor API (webview based editors) on-testplan under-discussion Issue is under discussion for relevance, priority, approach
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Feb 27, 2020

Refs #91325

I think for a non-text custom editor, it needs to expose a revert method. I know we could play-back all edits we got, but for normal files a revert will actually re-read the file from disk. This may have different semantic for custom editors too.
@mjbvz mjbvz added this to the March 2020 milestone Feb 27, 2020
@mjbvz mjbvz added api custom-editors Custom editor API (webview based editors) under-discussion Issue is under discussion for relevance, priority, approach labels Feb 27, 2020
@mjbvz
Copy link
Contributor

mjbvz commented Feb 27, 2020

Yes my intent was to use undoEdits/applyEdits for this but having an explicit revert method may be helpful

@mjbvz mjbvz closed this as completed in 033a5d4 Mar 9, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
api custom-editors Custom editor API (webview based editors) on-testplan under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @mjbvz