Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #91725 #91738

Merged
merged 2 commits into from Feb 28, 2020
Merged

Fix #91725 #91738

merged 2 commits into from Feb 28, 2020

Conversation

sandy081
Copy link
Member

This PR fixes #91725

Remove console.log

@sandy081 sandy081 added this to the February 2020 milestone Feb 28, 2020
@sandy081 sandy081 self-assigned this Feb 28, 2020
joaomoreno
joaomoreno approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risky, but I feel confident!

@sandy081
Copy link
Member Author

I agree too, but no other option 😉

@sandy081 sandy081 merged commit 66fea6e into master Feb 28, 2020
@sandy081 sandy081 deleted the sandy081/fix91725 branch February 28, 2020 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
February 2020
Development

Successfully merging this pull request may close these issues.

Sync uses console.log
2 participants
@sandy081 @joaomoreno