Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off JSON item resolving. Fixes #91747 #91749

Merged
merged 1 commit into from Feb 28, 2020
Merged

Turn off JSON item resolving. Fixes #91747 #91749

merged 1 commit into from Feb 28, 2020

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Feb 28, 2020

This PR fixes #91747

Turn off resolving for JSON completion items as the current JSON language service does nothing in resolving (it used to when package.json NPM completions were part of it)

@aeschli aeschli self-assigned this Feb 28, 2020
@aeschli aeschli added this to the February 2020 milestone Feb 28, 2020
@aeschli aeschli merged commit 0cd0f7d into master Feb 28, 2020
@aeschli aeschli deleted the aeschli/91747 branch February 28, 2020 10:54
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[json] error log entries on code completions
2 participants