Sort by category only once #91907
Merged
Sort by category only once #91907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
approved these changes
Mar 2, 2020
| @@ -260,6 +260,17 @@ export class BulkFileOperations { | |||
| } | |||
| } | |||
|
|
|||
| // sort (once) categories atop which have unconfirmed edits | |||
| this.categories.sort((a, b) => { | |||
There was a problem hiding this comment.
Should we switch to use a stable sort such as mergeSort from array.ts? (not sure if that would have fixed the original problem or not)
There was a problem hiding this comment.
I think by now all sort-implementations are stable (by spec update and implementation) and that can get rid of mergeSort
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #91900
Categories/groups in the refactor view that have unconfirmed changes should be sort atop because they need user approval. However, this should happen only once, when the view's tree is populated and not all the time while the tree updates. This PR removes the category/group sort logic from the tree comparator to the generation of the tree input.