Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt edit setting option in settings editor #91953

Merged
merged 1 commit into from Mar 4, 2020
Merged

Adopt edit setting option in settings editor #91953

merged 1 commit into from Mar 4, 2020

Conversation

sandy081
Copy link
Member

@sandy081 sandy081 commented Mar 3, 2020

This PR fixes #89512

@sandy081 sandy081 added this to the March 2020 milestone Mar 3, 2020
@sandy081 sandy081 requested a review from roblourens March 3, 2020 13:30
@sandy081 sandy081 self-assigned this Mar 3, 2020
roblourens
roblourens approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! I had been thinking about how to do this for March.

@roblourens roblourens merged commit bedd22c into master Mar 4, 2020
@roblourens roblourens deleted the sandy081/implement89512 branch March 4, 2020 02:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@sandy081 sandy081

Labels
None yet
Projects
None yet
Milestone
March 2020
Development

Successfully merging this pull request may close these issues.

IPreferencesService.openSettings does not work with text based settings editor
2 participants
@sandy081 @roblourens