Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

searchActions: usage of any hides the null return type #91962

Closed
bpasero opened this issue Mar 3, 2020 · 0 comments
Closed

searchActions: usage of any hides the null return type #91962

bpasero opened this issue Mar 3, 2020 · 0 comments
Assignees
@sandy081
Labels
debt Code quality issues
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 3, 2020

Code:

vscode/src/vs/workbench/contrib/search/browser/searchActions.ts

Line 717 in 77fe565

let elementToFocus: any = null;

This hides the fact that the method may return null
@sandy081 sandy081 added the debt Code quality issues label Mar 3, 2020
@sandy081 sandy081 added this to the March 2020 milestone Mar 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @sandy081