quick pick - support standalone editor (+ support indentation picker) #92086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings support for
IQuickInputServiceto the standalone editor and thus opens the door to having shared code between workbench and editor in this area.To proof it, there is now indentation support through the picker for standalone implemented by the same code that drives this from the workbench:
Since the standalone editor is a bit more complex around adding widgets into it, the standalone implementation is now a delegate to the currently focused editor and then uses an editor overlay widget as container. I hope this makes sense.
//cc @alexdima @chrmarti