Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Editor] Keybindings to increase/decrease context lines. #92172

Closed
JacksonKearl opened this issue Mar 6, 2020 · 4 comments
Closed

[Search Editor] Keybindings to increase/decrease context lines. #92172

JacksonKearl opened this issue Mar 6, 2020 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality search-editor verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@JacksonKearl
Copy link
Contributor

No description provided.

@JacksonKearl JacksonKearl self-assigned this Mar 6, 2020
@JacksonKearl JacksonKearl added the feature-request Request for new features or functionality label Mar 6, 2020
@JacksonKearl JacksonKearl added this to the March 2020 milestone Mar 6, 2020
@JacksonKearl JacksonKearl added the verification-needed Verification of issue is requested label Mar 30, 2020
@JacksonKearl
Copy link
Contributor Author

{
"key": "alt+-",
"command": "decreaseSearchEditorContextLines",
"when": "inSearchEditor"
}

and

{
"key": "alt+=",
"command": "increaseSearchEditorContextLines",
"when": "inSearchEditor"
}

added to default keybindings.

@connor4312 connor4312 added the verified Verification succeeded label Apr 1, 2020
@connor4312
Copy link
Member

@JacksonKearl it looks like the default alt-binding is only on OSX. On Windows it's set as alt+l, on which toggleSearchEditorContextLines takes precedence. Is this intended?

Works well after reassigning it though.

@connor4312 connor4312 added verification-steps-needed Steps to verify are needed for verification and removed verified Verification succeeded labels Apr 1, 2020
@JacksonKearl
Copy link
Contributor Author

@connor4312 good catch, tracking in #94225.

@JacksonKearl
Copy link
Contributor Author

We can verify that tomorrow and for now verify this based on the existence of commands that, when bound, will do the thing.

@JacksonKearl JacksonKearl removed the verification-steps-needed Steps to verify are needed for verification label Apr 1, 2020
@rebornix rebornix added the verified Verification succeeded label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality search-editor verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants