Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orca not reading languages list #92324

Closed
isidorn opened this issue Mar 10, 2020 · 5 comments
Closed

Orca not reading languages list #92324

isidorn opened this issue Mar 10, 2020 · 5 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 10, 2020

In Ubuntu, Orca doesn't speak the language modes when pressing ctrl+k, m when in Code Insider's.
Ubuntu 20.04, Orca master (3.37.1 pre), Code Insider's 1.44.

  1. Start Orca.
  2. Load Code Insider's.
  3. If not in an editor, press ctrl+n to create one.
  4. Press ctrl+k, m for a language.
  5. Press up/down arrows, or start typing your favorite programming language.

Actual results: Orca only speaks the number of results found. For example, 1 of 59.
Expected results: Orca should speak the language name and the number of results found. For example, Python, 1 of 2.

@isidorn isidorn added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Mar 10, 2020
@isidorn isidorn self-assigned this Mar 10, 2020
@jvesouza
Copy link

When I'm in an editor and I press ctrl + k + m, I only hear the number of languages ​​found.
I press up arrow and down arrow but the orca is silent.
Am I doing something wrong?

@isidorn
Copy link
Contributor Author

isidorn commented Mar 10, 2020

The issue here seems to be that the @chrmarti Quick Input does not provide an accessibilityProvider to the list and manually sets it on each element. I believe this can cause to ariaLabels not being properly set and potetnially overwritten by the tree.

Thus I have pushed a potential fix for this. I have tried it out on my mac and now I see ariaLabel properly set with my fix.
@jvesouza can you please verify with vscode insiders tomorrow and let us know if it is now trully fixed for you.
fyi @bpasero since you are jumping on the new quick pick

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Mar 10, 2020
@isidorn isidorn added this to the March 2020 milestone Mar 10, 2020
@jvesouza
Copy link

I just updated the VSCode and coincidentally the update for this problem is present in this update.
As we say here in Brazil: "show de bola"!
Which means to say that it was excellent. Problem solved.
Congratulations and thank you.

@isidorn
Copy link
Contributor Author

isidorn commented Mar 10, 2020

Show de bola it is then :)
Great, adding verified label. Thanks for letting us know it works.

@isidorn isidorn added the verified Verification succeeded label Mar 10, 2020
@ajborka
Copy link

ajborka commented Mar 10, 2020

After updating to the newest build 20 minutes ago, I can verify that this bug is now fixed. Thanks for the quick work!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants