Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate viewlet-level progress indication to view-level #92400

Closed
eamodio opened this issue Mar 10, 2020 · 3 comments
Closed

Migrate viewlet-level progress indication to view-level #92400

eamodio opened this issue Mar 10, 2020 · 3 comments
Assignees
Labels
debt Code quality issues
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Mar 10, 2020

Refs: #92135

Now that we can support view-level progress indication, there doesn't seem like much reason to have viewlet-level progress.

This can also address the concerns here: #92136 (review)

/cc @bpasero @sbatten

@eamodio eamodio added the debt Code quality issues label Mar 10, 2020
@eamodio eamodio added this to the Backlog milestone Mar 10, 2020
@eamodio eamodio self-assigned this Mar 10, 2020
@bpasero
Copy link
Member

bpasero commented Mar 11, 2020

@eamodio I guess one problem is that extensions can still use API to report progress on the viewlet container right? I forgot about that when I suggested this, so we may not easily be able to remove this.

@eamodio
Copy link
Contributor Author

eamodio commented Mar 11, 2020

Yeah, we won't be able to remove it, but we could deprecate it to encourage view-level use.

I've added an API proposal here for extensions: #92421

@eamodio
Copy link
Contributor Author

eamodio commented Oct 7, 2020

Since we really only expose ProgressLocation.SourceControl (and it is kind of special), I don't think its worth doing anything here.

@eamodio eamodio closed this as completed Oct 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues
Projects
None yet
Development

No branches or pull requests

2 participants