Add some notebook commands #92404
Merged
Add some notebook commands #92404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
changed the title
rebornix
approved these changes
Mar 12, 2020
| title: 'Execute Notebook Cell', | ||
| keybinding: { | ||
| when: ContextKeyExpr.and(NOTEBOOK_EDITOR_FOCUSED, InputFocusedContext), | ||
| primary: KeyMod.WinCtrl | KeyCode.Enter, |
There was a problem hiding this comment.
My only concern with this keybinding is it conflicts with "add line below" on Windows.
There was a problem hiding this comment.
Oh, right. Any other idea? We might have to use something besides 'enter', I feel like alt+enter might do something on windows?
roblourens
force-pushed
the
roblou/focusNextCellAfterExecute
branch
from
ca8adeb
to
3f3dcf1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There sure are a lot of null checks here.