Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide screen reader users a keyboard shortcut to jump between settings tree and settings panel #92487

Closed
ajborka opened this issue Mar 11, 2020 · 10 comments
Assignees
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues

Comments

@ajborka
Copy link

ajborka commented Mar 11, 2020

@isidorn: Screen reader users don't have a reliable method of jumping between the settings tree and the settings panel where the settings reside. This makes navigating the settings window difficult because we can lose our place in either the settings panel or the tree.

  • VSCode Version: 1.44 (Insider's)
  • OS Version: Windows 10 (1909), Ubuntu 20.04

Steps to Reproduce:

  1. Start JAWS or NVDA on Windows, or Orca in Linux.
  2. Start vscode.
  3. Press ctrl+, (comma) for settings.
  4. attempt to jump between settings tree and settings panel.

Actual results: There is no reliable method for this. The user must rely on screen reader features to navigate, which may or may not be reliable. In the case of Orca, settings in the settings panel is not accessible with arrow keys unless the user presses TAB from the settings tree first.
Expected results: The screen reader user can press a keyboard shortcut to navigate between settings tree and settings panel. The keyboard shortcut should remember last position and return the user to that location.
Does this issue occur when all extensions are disabled?: Yes

@vscodebot
Copy link

vscodebot bot commented Mar 11, 2020

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@isidorn
Copy link
Contributor

isidorn commented Mar 11, 2020

@ajborka this is great feedback. Thanks for sharing. I agree with this, we should have a keyboard shortcuts to move focus between the settings Table of Content s and the actual Content.
Assigning to @roblourens since he owns the settings UI. Is it possible to introduce such a command? If you are busy could you provide some code pointers so we open this to the community?

@ajborka as a workaround I suggest you try using F1 > open settings (JSON), as that might be easier to use with a screen reader - give it a try.

@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Mar 11, 2020
@roblourens roblourens added this to the March 2020 milestone Mar 22, 2020
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Mar 22, 2020
@roblourens
Copy link
Member

I added a command but can anyone suggest a keybinding that makes sense and isn't taken? Or we can leave it for users to pick their own keybinding.

@isidorn
Copy link
Contributor

isidorn commented Mar 23, 2020

@roblourens I think leaving this up to the users is perfectly fine.
Or for example ctrl + k, ctrl + c
K to start the chord, c for contents. Or t instead of c for table

For reference the name of the command is settings.action.focusTOC

@ajborka
Copy link
Author

ajborka commented Mar 23, 2020

The normal keyboard shortcut to cycle forward in a situation like this is f6 and the reverse is shift+f6. The best is to leave it for people to define.

@isidorn
Copy link
Contributor

isidorn commented Apr 3, 2020

@roblourens I could not find this command anywhere. I looked in the command palette (while in the settings UX) for "Focus Settings TOC tree"
I also looked for settings.focusSettingsTOC in keyboard shortcuts and I could not find it.
Thus reopening so we can clarify what I am missing. Thanks!

This is also not urgent so feel free to fix in next milestone if the fix is not trivial.

@isidorn isidorn reopened this Apr 3, 2020
@ajborka
Copy link
Author

ajborka commented Apr 3, 2020

@isidorn focus settings toc is settings.action.focusTOC. I couldn't find the other one though.

@isidorn
Copy link
Contributor

isidorn commented Apr 3, 2020

@ajborka thanks! Found it now.
I have verified that command focusses the table fo contents view. @roblourens should we also add that command to the command palette so users can discover it?

@roblourens
Copy link
Member

Yes

@roblourens roblourens modified the milestones: March 2020, April 2020 Apr 3, 2020
@roblourens roblourens modified the milestones: April 2020, May 2020 Apr 28, 2020
@roblourens roblourens modified the milestones: May 2020, June 2020 Jun 2, 2020
@roblourens roblourens modified the milestones: June 2020, July 2020 Jun 30, 2020
@roblourens
Copy link
Member

#92935

@roblourens roblourens removed this from the July 2020 milestone Jul 10, 2020
@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Jul 10, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Aug 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

3 participants