Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick input: should reserve space for actions? #92489

Closed
bpasero opened this issue Mar 11, 2020 · 5 comments
Closed

Quick input: should reserve space for actions? #92489

bpasero opened this issue Mar 11, 2020 · 5 comments
Assignees
Labels
*as-designed Described behavior is as designed quick-pick Quick-pick widget issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 11, 2020

When showing both separator and action I wonder if the toolbar should push out the separator always even when hidden to have a more consistent look:

image

In other words, a hidden toolbar reserves space still.

Does that make sense?

@bpasero bpasero added the quick-pick Quick-pick widget issues label Mar 11, 2020
@chrmarti
Copy link
Contributor

This is consistent with other places (Debug stack view comes to mind). It might be problematic when there are several actions because more space needs to be reserved. /cc @isidorn @sandy081

@chrmarti chrmarti added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 12, 2020
@bpasero
Copy link
Member Author

bpasero commented Mar 12, 2020

With 1 action and groups:

image

With multiple actions and groups (we do not use this I think, especially more than 1 action with separators):

image

When scrolled out of view:

image

not too bad I would say.

CSS changes:

https://gist.github.com/bpasero/95a2e48e7c20ef63ed21f0b2163a13fd

@isidorn
Copy link
Contributor

isidorn commented Mar 12, 2020

The location should be fixed, the actions should not push other things so UI is stable and not flickery.
Call Stack is not doing it proper imho.

@chrmarti
Copy link
Contributor

Sounds good. @bpasero Could you push your fix?

@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Mar 12, 2020
@chrmarti chrmarti added this to the March 2020 milestone Mar 12, 2020
@bpasero
Copy link
Member Author

bpasero commented Mar 12, 2020

Yes, can do that. If we think it behaves odd we can always revert, I do not have very strong feelings.

@bpasero bpasero added *as-designed Described behavior is as designed and removed bug Issue identified by VS Code Team member as probable bug labels Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants