Search in Panel sizing error

[rebornix]

Issue Type: Bug

• Open Search in Panel
• Cmd+down to move focus to the include pattern input box

VS Code version: Code - Insiders 1.44.0-insider (1df2355, 2020-03-12T05:29:05.555Z)
OS version: Darwin x64 19.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	32.00GB (0.22GB free)
Process Argv	-psn_0_39531953
Screen Reader	no
VM	0%

Extensions (14)

Extension	Author (truncated)	Version
comment-tagged-templates	bie	0.3.0
github-markdown-preview	bie	0.0.2
markdown-emoji	bie	0.0.9
markdown-preview-github-styles	bie	0.1.6
gitlens	eam	10.2.1
vscode-pull-request-github-insiders	Git	2020.3.8167
vscode-language-pack-zh-hans	MS-	1.43.7
remote-ssh-edit-nightly	ms-	2020.3.13860
remote-ssh-nightly	ms-	2020.3.13860
js-debug-nightly	ms-	2020.2.2917
debugger-for-chrome	msj	4.12.6
kuskus-extensions-pack	ros	1.0.1
kuskus-kusto-language-server	ros	1.0.1
kuskus-kusto-syntax-highlighting	ros	1.1.8

(4 theme extensions excluded)

[rebornix]

@sbatten @roblourens does any one of you get a chance to take a look? I'm still seeing this issue in today's Insiders.

[roblourens]

Investigating

[roblourens]

@sbatten maybe related to 2b02967

I think SearchView calls this.layout with its last height, but now that method is also using the given size for the width? Is this how I should call it now? Seems to fix the issue

this.layout(this._orientation === Orientation.VERTICAL ? this.size.height : this.size.width);

[sbatten]

that looks right, if overriding or sending its own layout calls, we need to send the right dimension