Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codicons are not vertically centered #92643

Closed
isidorn opened this issue Mar 13, 2020 · 2 comments
Closed

Codicons are not vertically centered #92643

isidorn opened this issue Mar 13, 2020 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Mar 13, 2020

@misolori assigning first to you and feel free to assign back to me.

  1. Debug two sessions such that the Debug Session is shown in the CallStack view
  2. Hover over a session -> notice how the debug actions are not vertically centered

Screenshot 2020-03-13 at 13 55 20

Easy way to debug two sessions:
Have the following test.js file:

console.log('hello');

Have the following launch.json and run both configurations:

{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program",
            "program": "${workspaceFolder}/test.js"
        },
        {
            "type": "node",
            "request": "launch",
            "name": "Launch Program2",
            "program": "${workspaceFolder}/test.js"
        }
    ]
}
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 13, 2020
@miguelsolorio miguelsolorio changed the title CallStack codicons not centerted Codicons are not vertically centered Mar 16, 2020
@miguelsolorio
Copy link
Contributor

I made a recent a change (ee04d73) that removed the vertical alignment on codicons and used an alternate method via flexbox. However this caused some codicons in list views to be off-centered. I've updated it so that all codicons now use the same method.

Verification steps: verify that codicons are vertically centered in:

  1. Debug viewlet w/ multiple debug sessions (see original post)
    image

  2. SCM actions
    image

  3. Custom views like Timeline and NPM Scripts
    image

@miguelsolorio miguelsolorio added this to the March 2020 milestone Mar 16, 2020
@isidorn
Copy link
Contributor Author

isidorn commented Mar 16, 2020

Looks good now, adding verified label. Thanks

@isidorn isidorn added the verified Verification succeeded label Mar 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants