Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick input: flickers when changing picks #92853

Closed
bpasero opened this issue Mar 17, 2020 · 1 comment
Closed

Quick input: flickers when changing picks #92853

bpasero opened this issue Mar 17, 2020 · 1 comment
Assignees
@bpasero
Labels
quick-pick Quick-pick widget issues
Milestone
March 2020

Comments

@bpasero
Copy link
Member

bpasero commented Mar 17, 2020 •
edited

Steps to Reproduce:

  1. git co ben/quick-access-anything
  2. F1
  3. select "Quick Access"
  4. start typing

This shows best with editor history (some editors opened in the past).

Kapture 2020-03-17 at 15 24 05
@bpasero bpasero added the quick-pick Quick-pick widget issues label Mar 17, 2020
@bpasero bpasero added this to the March 2020 milestone Mar 18, 2020
@bpasero bpasero assigned bpasero and unassigned chrmarti Mar 18, 2020
@bpasero
Copy link
Member Author

bpasero commented Mar 18, 2020

I was able to fix this on my end by avoiding picker.items unless needed. I think the behaviour as seen was correct because I was calling picker.items twice.

@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
quick-pick Quick-pick widget issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
2 participants
@bpasero @chrmarti