Suggestion (all lists?) styles are different in notebook

[jrieken]

See attached screen shots: Upper is notebook, lower is editor. The styles are very different, e.g

• background color
• no hover color
• selection color

[jrieken]

This happens because of these overwrite styles. Not sure why they bleed into the suggest widget (and other lists/trees, like peek references)

vscode/src/vs/workbench/contrib/notebook/browser/notebookEditor.ts

Line 201 in 6852fbc

overrideStyles: {

[rebornix]

The styler for list view only protects itself from leaking to list views externally, for all nested list views, they are all affected by the styler.

For example, the default styler used by the ListWidget will inject following style

`.monaco-list${suffix}:focus .monaco-list-row.focused { color: ${styles.listFocusForeground}; }`

As you can see from above, any .monaco-list-row inside .monaco-list${suffix} will inherit this rule.

IMHO the rule should be as restrict as

`.monaco-list${suffix}:focus > div.monaco-scrollable-element > .monaco-list-rows > .monaco-list-row.focused { color: ${styles.listFocusForeground}; }`

but I'm not confident to push this change to ListWidget, I'm sure it will break tons of list view which accidentally rely this loose rule. As a workaround, I plugin our own Styler for NotebookCellList, which only applies the CSS rules on the root list.

// @joaomoreno , @roblourens