"Retry as sudo" claims it "failed to save" but it actually succeeded

[Nowaker]

• VSCode Version:

Version: 1.43.1
Commit: fe22a9645b44368865c0ba92e2fb881ff1afce94
Date: 2020-03-18T07:17:38.324Z
Electron: 7.1.11
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Linux x64 5.5.11-arch1-1

• OS Version: Arch Linux 20200317

Steps to Reproduce:

0. Run VS Code as non-root.
1. Edit a file owned by root.
2. Try to save.
3. Error. Click "Retry as sudo".
   
4. Authenticate successfully.
5. See the error.
6. Inspect the file with an external editor. File has changed. It had succeeded contrary to what VS Code said.

Conclusion:

The printed "errors" were just warnings. VS Code thought what's in stderr is errors. Which is wrong as stderr is just warnings unless exit status is non-zero.

My environment is very unusual: using Cinnamon (a GTK+ desktop) with kde-sudo. While I don't know why kde-sudo was used instead of its GTK+ equivalent, that's what VS Code used and I had no choosing over it.

Does this issue occur when all extensions are disabled?: Yes

[Nowaker]

Thanks @bpasero!

[github-actions]

This bug has been fixed in to the latest release of VS Code Insiders!

@Nowaker, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version d7d1147 of Insiders (today's or later - you can use Help: About in the command pallete to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!