Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compact Folders: context menu uses the wrong folder path #93709

Closed
testforstephen opened this issue Mar 30, 2020 · 4 comments
Closed

Compact Folders: context menu uses the wrong folder path #93709

testforstephen opened this issue Mar 30, 2020 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@testforstephen
Copy link

testforstephen commented Mar 30, 2020

Can reproduce in 1.43.2 and 1.44 insider.

Opening a folder with the following structure, and enable compact folders.

- learning
  - src
    - main

Contribute customized context menus via contributes.menus-> explorer/context in package.json.
Then hover at src or main folder to trigger the context menu action, the uri parameter in the command callback will always point to the same folder main.

@isidorn
Copy link
Contributor

isidorn commented Apr 2, 2020

@testforstephen great catch, thanks for reporting this. I have pushed a fix and VS Code insiders from Friday should have the fix.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug author-verification-requested Issues potentially verifiable by issue author labels Apr 2, 2020
@github-actions
Copy link

github-actions bot commented Apr 3, 2020

This bug has been fixed in to the latest release of VS Code Insiders!

@testforstephen, you can help us out by confirming things are working as expected in the latest Insiders release. If things look good, please leave a comment with the text /verified to let us know. If not, please ensure you're on version 0dbae20 of Insiders (today's or later - you can use Help: About in the command pallete to check), and leave a comment letting us know what isn't working as expected.

Happy Coding!

@testforstephen
Copy link
Author

/verified

works in the latest insider version.

@isidorn
Copy link
Contributor

isidorn commented Apr 3, 2020

Thanks!

@isidorn isidorn added the verified Verification succeeded label Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants
@isidorn @testforstephen and others