Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook document metadata fields should be optional #93815

Closed
roblourens opened this issue Mar 31, 2020 · 3 comments
Closed

Notebook document metadata fields should be optional #93815

roblourens opened this issue Mar 31, 2020 · 3 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Milestone
March 2020

Comments

@roblourens
Copy link
Member

The properties in NotebookDocumentMetadata should be optional, with their defaults mixed in, right @rebornix?
@roblourens roblourens added feature-request Request for new features or functionality notebook labels Mar 31, 2020
@vscodebot vscodebot bot added this to the Backlog Candidates milestone Mar 31, 2020
@vscodebot
Copy link

vscodebot bot commented Mar 31, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@roblourens
Copy link
Member Author

And defaults are not mixed in for cell metadata, I left this unfinished.

@rebornix rebornix removed their assignment Mar 31, 2020
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Apr 1, 2020
@RMacfarlane RMacfarlane added the verification-steps-needed Steps to verify are needed for verification label Apr 3, 2020
@RMacfarlane
Copy link
Contributor

@roblourens What's the best way to verify this?

@roblourens roblourens added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Apr 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug notebook verified Verification succeeded
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
4 participants
@roblourens @rebornix @Tyriar @RMacfarlane