Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug "Call Stack" view has extra margin #93824

Closed
bpasero opened this issue Mar 31, 2020 · 5 comments
Closed

Debug "Call Stack" view has extra margin #93824

bpasero opened this issue Mar 31, 2020 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2020

image

See not aligned.

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 31, 2020
@bpasero bpasero changed the title Debug "Call Stack" view has margin Debug "Call Stack" view has extra margin Mar 31, 2020
@isidorn isidorn added this to the March 2020 milestone Mar 31, 2020
@ghosej
Copy link

ghosej commented Apr 1, 2020

Is this something that the community can work on? If so, I would like to work on this.

@isidorn
Copy link
Contributor

isidorn commented Apr 1, 2020

@ghosej thanks for offering. We are currently in the endgame week which means we are quickly fixing the last remaining issues before we ship. Due to that I will probably try to fix this bug in the next 8 hours. If you have a solution before than feel free to submit a PR.
Otherwise I recommend looking at issues with a help-wanted tag, or at issues not assigned to March milestone. Thanks

@isidorn
Copy link
Contributor

isidorn commented Apr 1, 2020

This was broken via #92294
On this line

@sbatten why do we add maring-left of 7px to all first child of a title? This breaks the call stack view.
I can fix this on the call stack view, however that would be the workaround. It would be ideal if we tackle this at the core of the issue thus assigning also to @sbatten

@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

V0 of multipanel had no collapse so I think this is just a remnant of that. I am removing.

@sbatten sbatten closed this as completed in 726c17a Apr 1, 2020
@sbatten
Copy link
Member

sbatten commented Apr 1, 2020

To Verify:

  1. Check that Call Stack view in the Run Viewlet does not have misaligned padding compared to other views.
  2. Check other views as well to ensure this fix does not break others.

@bpasero bpasero added the verified Verification succeeded label Apr 2, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants